Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEDI3 crashes on dual-processor systems #2

Open
Jensenbeatrice opened this issue May 12, 2019 · 9 comments
Open

EEDI3 crashes on dual-processor systems #2

Jensenbeatrice opened this issue May 12, 2019 · 9 comments

Comments

@Jensenbeatrice
Copy link

Good afternoon, on dual-processor systems such as mine, for example, quite often crashes EEDI3 when allocating memory.
The script is used like this:
def Mahou_Tsukai_no_Yome(clip):
gray = core.std.ShufflePlanes(clip, 0, GRAY)
desc = insaneAA.revert_upscale(gray, descale_strength=0.32, kernel='bilinear', descale_height=719)
rescale = insaneAA.rescale(desc, fasterAA=False, eedi3Mode='opencl', eedi3Device=0, nnedi3Mode='opencl', nnedi3Device=0, dx=1920, dy=1080, nsize=6)
aa = insaneAA.insaneAA(clip, externalAA=rescale, outputMode=0, inputMode=1)
mixyuv = core.std.ShufflePlanes([aa, clip, clip], [0,1,2], clip.format.color_family)
return mixyuv
(opencl or software result is used one - crashes in random places or at the start.
System:

Socket 1
Intel(R) Xeon(R) CPU E5-2687W 0 @ 3.10GHz
Socket 2
Intel(R) Xeon(R) CPU E5-2687W 0 @ 3.10GHz
Memory Type | DDR3
Memory Size | 64 GBytes
Channels | Dual
Mainboard Model | X9DRL-3F/iF
Display Adapters
NVIDIA GeForce RTX 2060
Windows Version | Microsoft Windows 10 (10.0) Professional 64-bit (Build 17763)
DirectX Version | 12.0

Dump: https://drive.google.com/file/d/1D6yFxnsidBupkY7DOVYdHosfPNMlW9K6/view?usp=sharing

Thanks in advance for corrections.

@HolyWu
Copy link
Member

HolyWu commented May 12, 2019

Hi, could you try the following lines without using script functions at all to make sure it's still reproducible?

clip = core.std.ShufflePlanes(clip, 0, vs.GRAY)
clip = core.resize.Spline36(clip, 1280, 720)
clip = core.eedi3m.EEDI3CL(clip, field=1, dh=True, gamma=1000.0, vcheck=3, sclip=core.nnedi3cl.NNEDI3CL(clip, field=1, dh=True, nsize=0, nns=4, pscrn=1))
clip = core.std.Transpose(clip)
clip = core.eedi3m.EEDI3CL(clip, field=1, dh=True, gamma=1000.0, vcheck=3, sclip=core.nnedi3cl.NNEDI3CL(clip, field=1, dh=True, nsize=0, nns=4, pscrn=1))
clip = core.std.Transpose(clip)

@Jensenbeatrice
Copy link
Author

Jensenbeatrice commented May 12, 2019

using script functions
Yes, and crashes...
https://drive.google.com/file/d/1PqFkokFxoywnX0N0zmzfdUA_8bU8pBrj/view?usp=sharing

@HolyWu
Copy link
Member

HolyWu commented May 12, 2019

Does using cpu version instead of opencl version still crash? For exmaple:

clip = core.std.ShufflePlanes(clip, 0, vs.GRAY)
clip = core.resize.Spline36(clip, 1280, 720)
clip = core.eedi3m.EEDI3(clip, field=1, dh=True, gamma=1000.0, vcheck=3, sclip=core.znedi3.nnedi3(clip, field=1, dh=True, nsize=0, nns=4, pscrn=1))
clip = core.std.Transpose(clip)
clip = core.eedi3m.EEDI3(clip, field=1, dh=True, gamma=1000.0, vcheck=3, sclip=core.znedi3.nnedi3(clip, field=1, dh=True, nsize=0, nns=4, pscrn=1))
clip = core.std.Transpose(clip)

If that still crashes, could you try forcing vspipe to spawn threads on only one processor?

@Jensenbeatrice
Copy link
Author

Jensenbeatrice commented May 12, 2019

Does using cpu version instead of opencl version still crash?

No.
Also, If you limit the number of threads to 8 (1 cpu +opencl), the crashes do not happen.

@Jensenbeatrice
Copy link
Author

Checked on old video card drivers (417), there are crashes (but less often than the last drivers 430), also checked on another machine (2 cpu) with gtx 760 and old drivers, there are also crashes.

@HolyWu
Copy link
Member

HolyWu commented Jun 17, 2019

Sorry for late response. Could you try again with https://www.mediafire.com/file/kq2hsexa7mbopk7/EEDI3-test.7z/file and provide the crash dump? Thanks.

@Jensenbeatrice
Copy link
Author

Jensenbeatrice commented Jun 18, 2019

@HolyWu
Copy link
Member

HolyWu commented Jun 19, 2019

Sigh. I still can't hunt down the culprit after tracing the call stack and don't understand why it only crashes on systems with more than one CPU. Anyway, please test https://www.mediafire.com/file/4qgmoeod9gi6r27/EEDI3m-test2.7z/file again. If it still crashes, I'm going to give up then.

@Jensenbeatrice
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants