Update the "more verbose" tutorial example #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two changes here, one of which may be a bit contentious. I really enjoyed working through this, but I was thrown by the final comments concerning 167. What's so different about 167 compared to 168? I found the program generator was quite happy to come up with a program for both. I thought it might be interesting therefore if the 167 example was something that the program generator was not able to solve. This, I think, makes it more interesting and also emphasises that the software is doing what the user would expect (i.e. not coming up with a solution that doesn't exist). This change therefore constrains the values to being even, so that the 167 result can't be obtained. The second, smaller change, is to use 'Number# instead of 'Real'. I was uncomfortable with the latter simply because, even in the original version, they are in fact all integers. I understand if you feel these changes are making things overly complicated. I just thought they'd make an interesting example.
|
@pwochner, for your consideration. |
pwochner
requested changes
Oct 29, 2024
pwochner
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes here, one of which may be a bit contentious. I really enjoyed working through this, but I was thrown by the final comments concerning 167. What's so different about 167 compared to 168? I found the program generator was quite happy to come up with a program for both.
I thought it might be interesting therefore if the 167 example was something that the program generator was not able to solve. This, I think, makes it more interesting and also emphasises that the software is doing what the user would expect (i.e. not coming up with a solution that doesn't exist).
This change therefore constrains the values to being even, so that the 167 result can't be obtained.
The second, smaller change, is to use 'Number' instead of 'Real'. I was uncomfortable with the latter simply because, even in the original version, they are in fact all integers.
I understand if you feel these changes are making things overly complicated. I just thought they'd make an interesting example.