Drop 8 and 9 card testing cases #93 #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think you might know but the |
HenryRLee
force-pushed
the
fix_dptable_test_todo
branch
from
20a085e to
4c51e8c
Compare
|
Yeah, let me clean up the table then. There are many cells generated for 8-card and 9-card. But we don't need them now. |
HenryRLee
force-pushed
the
fix_dptable_test_todo
branch
from
4c51e8c to
b96c7fd
Compare
HenryRLee
force-pushed
the
fix_dptable_test_todo
branch
from
b96c7fd to
24d61fd
Compare
|
I think I need to put this on hold. Cleaning up the whole table has some risks without having a unit test covering the evaluation results. Currently, our Python test coverage is very small and all the test cases are fixed scenarios. We may miss some edge cases if not being careful. |
|
I'll make this PR depends on issue #99. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8-card evaluator and 9-card evaluator had been deprecated, we no longer need to test these two cases in the test code.