Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #18

Open
1 of 5 tasks
ghost opened this issue Jul 28, 2024 · 3 comments
Open
1 of 5 tasks

Some suggestions #18

ghost opened this issue Jul 28, 2024 · 3 comments
Labels
enhancement New feature or request feature request New feature related. good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Jul 28, 2024

Your work on UI is great. But there is some sort of need to work on content and working.

  • 1. All chart are showing songs from YT.It should prioritise ji0Savan as it provides 320kbps instead of max 160kbps by YT.
  • 2. There should be a choice to choose between savan and YT. (I know you have provided in setting but that that doesn't work. All charts are from YT.)(bug)
  • 3. For YT if possible try to implement sponsorblock api to remove extra parts from songs. Also for YT if possible thumbnail should be provided by any other provider.
  • 4. Swipe in queue list to remove any song and reorder to rearrange them in list.
  • 5. LRCLIB as lyrics source(best open source lrc provider)
@HemantKArya
Copy link
Owner

Your work on UI is great. But there is some sort of need to work on content and working.

Thanx @Its-Tony

  1. you are right about Saavan one that it provides higher quality audio but there is another problem with Saavan that it doesn't work in most of the countries. Mostly support south Asian and middle Asian countries so that's why opted for YT charts. But still if there is another idea in between then I am open for any discussion.
  2. About the option for chart, sponsor block Api, and reordering in queue according to user, it's a good idea and I was thinking from start to implement this but right now there are various another important feature is still pending. So, I guess after that done, we can also implement that or may be if someone submit a good PR for that I will completely welcome support.

It's good to hear that you noticed so many things and it will be a good start for improving this project even more. Till then you can submit a different issue thread for those different feature, it will surely help this project.

@HemantKArya HemantKArya added enhancement New feature or request good first issue Good for newcomers feature request New feature related. labels Jul 29, 2024
@ghost
Copy link
Author

ghost commented Aug 5, 2024

About Saavn charts: you can keep YT as default but provide an option inside setting to toggle b/w Saavn and YT.

@HemantKArya
Copy link
Owner

Yeah that sounds good I will make sure to look into this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request New feature related. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant