Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tag of "AM-ADV" appears to be classified as that of "V". #2

Open
smiyawaki0820 opened this issue May 11, 2020 · 2 comments
Open

Comments

@smiyawaki0820
Copy link

The label of "AM-ADV" (or "C-V") appears to be wrongly classified as the tag of "V" in order to use the condition of "V" in label (judgement for a verb), when I used the script of "CoNLL_to_JSON.py" to create data for the model.

The relevant part of the script is in https://github.com/Heidelberg-NLP/SRL-S2S/blob/master/pre_processing/CoNLL_Annotations.py#L197

@angel-daza
Copy link
Member

The cases of AM-ADV and C-V should be caught by one of the first portions of the IF statement [ Namely self.op_lbl_05.match(lbl) ]

@smiyawaki0820
Copy link
Author

I am grateful for your answer and as you have indicated such labels seem to be actually caught by the first part of the IF statement.

However, in the case of a label whose span is composed of one word, like (AM-ADV*), would not be caught by the above portions: if self.op_lbl_05.match(lbl) and ")" not in lbl:.

And also, in order to use not search but match function of the methods of regular expressions, this label would not be caught by the second portion capturing a closing label: elif self.cl_lbl_05.match(lbl): (self.cl_lbl_05 is equal to re.compile('\\*\\)').)

For this reason, the label of (AM-ADV*) might be classified as the tag of V.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants