Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Known Issue] YTDLError: aborted on Node.js v16 #552

Closed
Hazmi35 opened this issue Jul 17, 2021 · 3 comments · Fixed by #553
Closed

[Known Issue] YTDLError: aborted on Node.js v16 #552

Hazmi35 opened this issue Jul 17, 2021 · 3 comments · Fixed by #553
Labels
bug Something isn't working fixed by workaround

Comments

@Hazmi35
Copy link
Owner

Hazmi35 commented Jul 17, 2021 •
edited
Loading

This is an issue with ytdl-core x Discord.js on Node.js v16 (16.5.0), related to fent/node-ytdl-core#902, #547
@Hazmi35
Copy link
Owner Author

Hazmi35 commented Jul 17, 2021

Playing with highWatermark fixes the issue?

@Hazmi35 Hazmi35 linked a pull request Jul 17, 2021 that will close this issue
fix(YouTube): set highWaterMark to "1048576 * 32 (32MiB)" #553
Merged
@Hazmi35
Copy link
Owner Author

Hazmi35 commented Jul 17, 2021

Fixed in release Version 4.39.2, thanks for @FireUpdate for discovering this issue

@Hazmi35 Hazmi35 added bug Something isn't working fixed by workaround labels Aug 16, 2021
@Hazmi35
Copy link
Owner Author

Hazmi35 commented Aug 16, 2021

Marking this fix as a workaround. This issue is completely resolved in Jukebox v5 #293

Hazmi35 added a commit that referenced this issue Aug 16, 2021
@Hazmi35
fix(downloader): Remove highWaterMark
79117c1 
We don't need it anymore, this is a workaround for #552
That error doesn't appear anymore on the new @discordjs/voice
And setting highWaterMark on the new voice system would cause lag
So I decided to delete the highWaterMark option instead.
Hazmi35 added a commit that referenced this issue Aug 16, 2021
@Hazmi35
feat: Migrate to Discord.js v13 (#624)
6ccb421 
* chore: Use Node v16

* chore(deps): Update discord.js

* chore(deps): Install @discordjs/voice

* feat: Switch to Node.js v16

* feat(AboutCommand): Migrate to Discord.js v13

* feat(EvalCommand): Migrate to Discord.js v13

* feat(HelpCommand): Migrate to Discord.js v13

* feat(InviteCommand): Migrate to Discord.js v13

* feat(PingCommand): Migrate to Discord.js v13

* feat(main): Migrate to Discord.js v13

* feat(config): Remove compat layer

* feat(bot): Migrate to Discord.js v13

* feat(Util): Migrate to Discord.js v13

* feat(createEmbed): Migrate to Discord.js v13

* feat(CommandManager): Migrate to Discord.js v13

* feat(ReadyEvent): Migrate to Discord.js v13

* feat(PlayCommand): Migrate non music methods

* feat(MessageEvent): Migrate to Discord.js v13

* chore: Comment file that hasn't migrated yet.

* feat(ServerQueue): Migrate to Discord.js v13

* feat(Guild): Migrate to Discord.js v13

* fix(MessageEvent): MessageEvent -> MessageCreateEvent

* feat(PlayCommand): Migrate to Discord.js v13

* chore(PlayCommand): Add todo for Volume support

* feat(NowPlayingCommand): Migrate to v13

* feat(commands): Migrate to Discord.js v13

* fix(PlayCommand): Return if serverQueue is undefined

* feat(PlayCommand): Wait 15 seconds for the connection to be ready before playing

* refactor(Util): Refactor getGuildsCount, getChannelsCount. getUsersCount, and getTotalPlaying

* chore(Util): Fix typings

* fix(Util): Use fs.readFile instead of importing it in getPackageJSON

* fix(getPackageJSON): Fix getPackageJSON no valid main entry when trying to get jukebox's package.json

* fix(AboutCommand): Fix malformed AboutCommand message caused by indents

* chore: fix typings

* feat(MusicHelper): Migrate to Discord.js v13

* fix(MusicHelper): this -> that

* fix(downloader): Remove highWaterMark

We don't need it anymore, this is a workaround for #552
That error doesn't appear anymore on the new @discordjs/voice
And setting highWaterMark on the new voice system would cause lag
So I decided to delete the highWaterMark option instead.

* fix(ServerQueue): General fixes for music commands

* feat(VolumeCommand): Migrate to Discord.js v13

* fix(PlayCommand): Remove this listener as it conflicts with VoiceStateUpdateEvent

* fix(PlayCommand): Don't send Start playing message when unpaused

* feat(VoiceStateUpdateEvent): Migrate to Discord.js v13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed by workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(YouTube): set highWaterMark to "1048576 * 32 (32MiB)" Hazmi35/jukebox
1 participant
@Hazmi35