Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No positive integration tests #15230

Open
DanielLipowicz opened this issue May 8, 2024 · 1 comment
Open

No positive integration tests #15230

DanielLipowicz opened this issue May 8, 2024 · 1 comment

Comments

@DanielLipowicz
Copy link

DanielLipowicz commented May 8, 2024

I review the API repository and I see that there is no positive integration testing at all. Because I've not found anything I decide to play a little with JS and I wrote additional scenario.

  it('returns an success when message and email is added', async () => {
    await expect(user.post('/bug-report', {
      message: 'Something is wrong here',
      email: user.auth.local.email,
    }))
      .to.eventually.to.contain({
        code: 200,
      });
  });

Before I spend more time on this I would like to ensure that this strategy is welcome in Habitica.
IMO covering this gap would provide more confidence to each changed done in scope of API and Clients.

Please let me know if you would like to see my contribution in tests here.
If you assign this ticket to me I will cover some endpoints and create PR with improved test coverage.

@DanielLipowicz
Copy link
Author

PR added #15232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant