Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Documentation for /notifications/read is incomplete #14484

Open
SabreCat opened this issue Feb 3, 2023 · 17 comments
Open

API Documentation for /notifications/read is incomplete #14484

SabreCat opened this issue Feb 3, 2023 · 17 comments

Comments

@SabreCat
Copy link
Member

SabreCat commented Feb 3, 2023

The API documentation for "Mark multiple notifications as read" is inaccurate.

There is a required parameter in the request body, notificationIds, specifying what notifications to mark as read, which doesn't show up in apidoc as yet. We don't currently have a blanket API route to dismiss all notifs without listing them.

@shivamAmrutia
Copy link

This is my first issue and i have no clue how to get started, can you please tell me how can i help ?

@TUdarbe
Copy link

TUdarbe commented Feb 5, 2023

Hi! I would like to pick up and work on this issue.

@KipronohVincent
Copy link

Hello I'm requesting for guidance on how to tackle this issue

@marnamrs
Copy link

Hi! I have looked into controller files and saw the missing @apiParam, I can pick this up and add the annotation.

@KipronohVincent
Copy link

KipronohVincent commented Feb 22, 2023 via email

@CuriousMagpie
Copy link
Member

Sure thing, @marnamrs! Thanks!

@apoorvapendse
Copy link

is this issue resolved?

@apoorvapendse
Copy link

apoorvapendse commented May 24, 2023

image
Do you want it to look like this?
@SabreCat @CuriousMagpie

@apoorvapendse
Copy link

@SabreCat @CuriousMagpie can i work on this?

@CuriousMagpie
Copy link
Member

Sure thing, @apoorvapendse! Thanks!

@apoorvapendse
Copy link

@CuriousMagpie Thanks for assigning, do you also need the same change for marking multiple notifications as seen?

@CiceroLino
Copy link

is this issue resolved? if not, can I work on this?

@apoorvapendse
Copy link

@CiceroLino I have created a pull request for the same, waiting for it to be reviewed.

@ducknows
Copy link

ducknows commented Dec 4, 2023

does anyone got an update on this issue if got reviewed or not?

@apoorvapendse
Copy link

@ducknows nope.

@nadasuhailAyesh12
Copy link

Can I work on this issue, could you assign me please

@anishlukk123
Copy link

@SabreCat can you review the pr associated with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests