#include "hsa_ext_finalize.h" should be "hsa_ext.h"

[markrankilor]

The official specification bundle for the HSA Runtime group includes a "hsa_ext.h" as a header, whereas the code here looks for "hsa_ext_finalize.h".

[gstoner]

I am going to let Boris know he needs to update this.

[BorisI]

Hi! The conformance suite needs HSAIL-Tools repository and two HSA Runtime header files pointed to by environment variables to be built.Detailed description is in the manual at docs/HsaPrmConformance.html, section "Building test suite". Does it work if you follow the description? Or do the build instructions look unclear, or somehow incorrect?

[BorisI]

I've updated instructions (https://github.com/HSAFoundation/HSA-Conformance-Tests-PRM/blob/master/docs/HsaPrmConformance.md#building-the-test-suite) in the test suite manual and added a reference to the document itself from the README file.

[markrankilor]

Yes, I am able to build the conformance suite if I work around these issues. That is no problem. I'm looking at this in the spirit of a standard conformance test. Currently the header the conformance test is looking for is hsa_ext_finalize.h and the spec bundle from the runtime group provides hsa_ext.h. One of these should be renamed.

[nhaustov]

I'll raise this with Mario.

[BorisI]

Mark,
thanks for a detailed report! please let me summarize existing problems how I see them, and how we're going to address them. Please add/correct if something is wrong or missing.

1. Header naming and usage across all HSA SW distributions should be consistent. We will review the existing distributions, agree on a unified approach, and fix the distributions as needed.
2. External dependencies (header files, make systems etc.) are okay for building conformance test suite, but unacceptable for running it. All files required for the test suite execution should be either a part of the conformance test suite package, or uniformly available through official HSA Foundation distributions. We'll review the found ones, look if there are others, and fix them.
3. Build instructions which look like a workaround need improvement. We'll get rid of unneeded steps.

Thanks for the great feedback! Please keep it coming :)