Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify config #32

Closed
HPWebdeveloper opened this issue Jun 26, 2024 · 5 comments
Closed

Modify config #32

HPWebdeveloper opened this issue Jun 26, 2024 · 5 comments

Comments

@HPWebdeveloper
Copy link
Owner

HPWebdeveloper commented Jun 26, 2024

'log_reference_length' => 12,

As the log reference is now flexible to get custom class and static methods like, random
I believe this 'log_reference_length' is not general and it should be 'log_reference_parmas' and the default value should be [12] instead of 12

In this way we let the params to have values like this [...,...,...]

@3m1n3nc3 Can you modify this?

@3m1n3nc3
Copy link
Contributor

I remember we had it this way initially before if was removed by a pull request, let do it.

@HPWebdeveloper
Copy link
Owner Author

@3m1n3nc3
Yes I see, #16 (comment)

The initial approach was too complex. please make it simple.

@3m1n3nc3
Copy link
Contributor

3m1n3nc3 commented Jun 26, 2024

I opened a new pull request #33

@HPWebdeveloper
Copy link
Owner Author

I opened a new pull request

thanks

@HPWebdeveloper
Copy link
Owner Author

HPWebdeveloper commented Jun 27, 2024

well done! @3m1n3nc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants