simplify PythiaConnector::makePapasParticlesFromGeneratedParticles

[alicerobson]

Discussion below. Should be possible to simplify makePapasParticlesFromGeneratedParticles, but will require a corresponding update to Python

@cbernet
it looks like this function can be optimized and simplified:

loop on ptcs
if selected (stable, etc)
create Particle
emplace in particles
sort particles
The sorting can probably be done with a simple, one-line call. no need to define a functor.

Sorting should be done according to pT if not on ee collider
@alicerobson
alicerobson an hour ago Member
Hi Colin
I completely agree that it could be simpler. However, if I am to match the pdebug outputs from python, I must first sort the generated particles and then create the papas particles from the sorted gen particles. Otherwise the identifiers of the particles differ between papas and cpp.
Would it be better to change the way it works in Python (and implement your comments above)?
@cbernet
cbernet 25 minutes ago Member
For now let's leave it like this.
At some point, we should change that on both the c++ and python sides. can you create an issue with low priority to keep track of that?