Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

review identifier naming scheme #39

Open
cbernet opened this issue Mar 15, 2017 · 3 comments
Open

review identifier naming scheme #39

cbernet opened this issue Mar 15, 2017 · 3 comments
Assignees

Comments

@cbernet
Copy link

cbernet commented Mar 15, 2017

good to keep the identifier as an integer, we don't want a class for that.

But then the class that manages the identifier is not an Indentifier.
Also, confusion with the index and the unique id.

Need to come up with names for:

  • the Identifier class
  • the identifier integer
  • the index
  • the unique id, which might denote either the whole identifier integer or the type + subtype + index...
@alicerobson
Copy link
Collaborator

Current proposal
IdCoder = the Identifier class
Identifier = the identifier integer
Index = the index
UniqueId = the unique id, for the type + subtype + index...

@cbernet
Copy link
Author

cbernet commented Mar 16, 2017

perfect.

alicerobson pushed a commit to alicerobson/papas that referenced this issue Mar 22, 2017
@cbernet
Copy link
Author

cbernet commented May 5, 2017

Done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants