Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards Not Updating on Dark/Light Mode Toggle #296

Closed
Abhik004 opened this issue Oct 16, 2024 · 5 comments · Fixed by #319
Closed

Cards Not Updating on Dark/Light Mode Toggle #296

Abhik004 opened this issue Oct 16, 2024 · 5 comments · Fixed by #319

Comments

@Abhik004
Copy link

📝 Description

When toggling between dark and light modes, only the background color of the page changes, but the card components retain their color, which causes visual inconsistencies. The card backgrounds and text colors should also switch between dark and light modes.

📷 Screenshot or Visual Reference (optional)

Screenshot 2024-10-16 105047
Screenshot 2024-10-16 105034

🐛 Bug Report (if applicable)

  • Steps to Reproduce:
    1.Load the page in light mode.
    2.Toggle to dark mode.
    3.Observe that the page background changes, but the card colors do not update accordingly.
  • Expected behavior: The background and text color of the cards should also toggle to match the selected theme (dark/light).
  • Actual behavior: The card components remain unchanged when toggling themes, causing them to stand out against the rest of the UI.

🌐 Additional Context

This issue impacts overall UI consistency and user experience, particularly when switching to dark mode. Proper theme handling across all components is essential for accessibility and design uniformity.

Copy link

Welcome, @Abhik004! Thanks for raising the issue.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
Make sure to star this awesome repository and follow the account!

@Abhik004
Copy link
Author

Kindly assign me this issue @Gyanthakur

@Gyanthakur
Copy link
Owner

push the changes.

@Gyanthakur
Copy link
Owner

@Abhik004 what's your update?

@Sushil010
Copy link
Contributor

@Gyanthakur I saw the issue was open and previous contributor was not responding so i have made changes and opened a PR. Will be glad to hear any changes if still required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants