Todo-Tree: Failed to find vscode-ripgrep

[Dovernh]

Todo-Tree: Failed to find vscode-ripgrep - please install ripgrep manually and set 'todo-tree.ripgrep' to point to the executable. using insiders, happened after an update to insiders

[Tyriar]

Version: 1.64.0-insider (user setup)
Commit: 753319a08f8e74700b1dba3a29bf0a6af7c2953f
Date: 2022-01-12T05:16:42.486Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

[Tyriar]

Oh I think this is probably because we migrated the module to @vscode/ripgrep https://www.npmjs.com/package/@vscode/ripgrep

[smlombardi]

@Tyriar so what should we end-users do?

[MariaSolOs]

I'm having the same issue :/

[roblourens]

@Gruntfuggly I wasn't expecting an extension to try to load a node module from the vscode install. Can you update the extension to point to @vscode/ripgrep instead?

For users, it looks like there is a setting todo-tree.ripgrep where you can point to your own ripgrep binary or point to node_modules/@vscode/ripgrep in your vscode install

[Tyriar]

I guess the best would be requiring based on the version of vscode, so >= 1.64 would use @vscode/ripgrep, that way you can remove the old case when the vscodeEngine is updated to 1.64+. We don't consider the modules shipped with VS Code public API but I know some extensions do it, created microsoft/vscode#140585 for discussion

[connor4312]

See #596

[Gruntfuggly]

@Dovernh Please can you try the latest version and see if it works with the new insiders build? (it did for me, but it's always good to get confirmation from somebody else! 😄 )

[MariaSolOs]

@Gruntfuggly It works for me! :)

[selrond]

Works now (insiders, latest version)

[Dovernh]

@Gruntfuggly Yes no errors this morning and the todo's now show

[geekley]

@Gruntfuggly Can you update open-vsx with latest version, please? Thanks.

[Gruntfuggly]

Done.