Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/Resistance lag #19

Open
abdullahtk opened this issue Dec 4, 2020 · 4 comments
Open

Support/Resistance lag #19

abdullahtk opened this issue Dec 4, 2020 · 4 comments

Comments

@abdullahtk
Copy link

Hello @GregoryMorse , Thank you for the great work.

After several months of playing and using the library, I found that when calculating support and resistance, most of the times it doesn't calculate the last day/minute points. Let say that I'm using daily data and calculating support and resistance on the high/low. Let's also say that last day is having long tail. When calculating S/R, it doesn't show that as a support. However, when we have a new data for the next day, the library shows the long tail as a support point as seen below:

Screen Shot 2020-12-04 at 1 28 19 PM

This is when calculating the S/R until the second to last data points. As you can see there is no support line here.


Screen Shot 2020-12-04 at 1 28 57 PM

This is when calculating S/R with the last data points and now there is a support line for the previous day (long tail)

Can you explain why is this happening? also, is there a way to fix this?

Thank you again for this great library.

@GregoryMorse
Copy link
Owner

I saw your email and I am responding. After thinking about it, yes you are right this is a problem. Because to be a "maxima" or "minima" it is assumed that the peaks and troughs are occurring in the middle. However, I realize this is a very legitimate practical problem and should be fixed. Its not the trend line functions, but the get_extrema like functions causing the issue. An option should be added for this. Likely its only needs at the tail of the data, not the beginning of it but why not give both options. This is a great point and thanks for the request, it will be added.

@abdullahtk
Copy link
Author

Thank you for your reply. I can't wait for that addition

@berlinguyinca
Copy link

any updates regarding this? This looks like a rather promising project!

@JeffStodd
Copy link

Perhaps you could do some forecasting to pad the end with the expected price movements after which get_extrema should be able to locate a min/max point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants