Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataNode: Only add the nodeid to the paths, if we differe from the default config #17181

Closed
wants to merge 3 commits into from
Closed

DataNode: Only add the nodeid to the paths, if we differe from the default config #17181

wants to merge 3 commits into from

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Nov 6, 2023

We have to check this because we have to make sure that we can work with existing OpenSearch directories if we're doing rolling upgrades.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise requested a review from todvora November 6, 2023 14:09
@janheise
Copy link
Contributor Author

closed, favoring #17255

@janheise janheise closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todvora todvora Awaiting requested review from todvora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janheise