Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect injection of builders in AWS service classes #680

Open
danotorrey opened this issue Dec 16, 2020 · 0 comments
Open

Incorrect injection of builders in AWS service classes #680

danotorrey opened this issue Dec 16, 2020 · 0 comments

Comments

@danotorrey
Copy link
Contributor

Description

It appears that the injection of the IamClientBuilder, KinesisClientBuilder and CloudWatchLogsClientBuilder in Integrations AWS Service classes is currently being done incorrectly. In the current implementation, a single instance of the builders is injected and reused for each client creation. I suppose this has no actual symptoms (unless there is some edge case I am not seeing), since the config properties are re-written each time the client is instantiated.

See example in CloudWatchService

See here for the registration of the builders.

I suggest that the change the constructors to instead inject a Provider<> or factory class instead that creates a new builder each time one is needed instead of reusing the same one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants