New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated temp files are not cleaned up #1

Open

slootjes opened this issue Apr 25, 2017 · 0 comments

slootjes commented Apr 25, 2017

On a site with many gif resizes my disk filled up quickly and I traced this back to the files being generated in ImageDescriptor.php:

$tFileS = tempnam("BewareOfGeeksBearingGifs", "grS");
$tFileD = tempnam("BewareOfGeeksBearingGifs", "grD");

After the resize is done and the file is closed I see:

unset($tFileD);
unset($tFileS);

while I assume this should be:

unlink($tFileD);
unlink($tFileS);

Also I'm not sure why tempnam() is called with "BewareOfGeeksBearingGifs" as directory, why not just use sys_get_temp_dir() for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment