Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the same margin around seats at the bottom as at the top #3

Closed
Gouvernathor opened this issue May 25, 2024 · 0 comments · Fixed by #5
Closed

Have the same margin around seats at the bottom as at the top #3

Gouvernathor opened this issue May 25, 2024 · 0 comments · Fixed by #5
Labels
enhancement New feature or request

Comments

@Gouvernathor
Copy link
Owner

Gouvernathor commented May 25, 2024

This would make the seat center calculations independant of the "seat radius factor", which is probably a feature as it would possibly make the entire geometry submodule independent of the seat radius factor - and we may even return a simple dict instead of a weird one with attributes.
It would also simplify (a great deal) the reflex angle calculations, including the fully-circular assemblies.

At the same time, it should be noted that the legacy (non-revamp) parliamentdiagram does not have such a margin at the bottom, it only appeared in the revamp code..

That would induce an API change, so a major version bump.

@Gouvernathor Gouvernathor added the enhancement New feature or request label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant