Contributor Onboarding Agreement

See Issue ID tracking: https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/issues/716

Contributor Onboarding Agreement

• TBD - procedures for repo contributors to follow when working with the public repository code
• TBD - legal review for Day 2 support text

COA 1: No Private Forks in Client GCP Organizations without Google Authorization

The default method of initial deployment of this repository is to be from the public repository - main or other public dev branch.

Day 2 Support: Any private fork repository deployment managed by a 3rd party partner for GCP clients that are part of Google Cloud oversight must be approved first.

COA 2: Pull Request Recommendations

• Have a github issue ID ready and link to it from the PR - describing the units of work for multi-PR work items
• Add the entire team for review discussion, visibility and coverage. An example is here https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/636
• Try not to merge the PR as soon as the minimum 2 reviewers have approved the PR - leave it open enough for several of the reviewers to comment on the PR
• Try to test the PR on a running landing zone and optionally for specific cases on a new landing zone optionally in a clean GCP organization
• For script changes both in the sh/bash scripts and snippets of scripts in readme.md files - fully test out the script to avoid runtime/syntax errors
• Optionally post some evidence of script execution and LZ deployment (we are still pending a full pipeline CD deployment)
• Add links to other PRs' Issue ids in the text and header like "#568 - description" above in PR 636