Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC-client-user-guide suggests using master #4

Open
ejona86 opened this issue Apr 24, 2018 · 0 comments
Open

gRPC-client-user-guide suggests using master #4

ejona86 opened this issue Apr 24, 2018 · 0 comments
Assignees

Comments

@ejona86
Copy link
Collaborator

ejona86 commented Apr 24, 2018

gRPC-client-user-guide.md suggests cloning current master from both protobuf and grpc:

$ git clone https://github.com/google/protobuf.git
$ cd $HOME/protobuf
$ ./autogen.sh && ./configure && make -j8
$ git clone https://github.com/grpc/grpc-java.git
$ cd grpc-java/compiler
$ ../gradlew java_pluginExecutable

If doing testing, that can be fine, but it will be trivially broken when gRPC or proto is enhancing its generated code. You should generate at a tagged version that matches the runtime version (of the deps in pom.xml), or older.

For example, if the version of gRPC in the Maven file is 1.9.0, then you may only use generated code from tagged releases from 1.9.0 and earlier.

@ZhouyihaiDing ZhouyihaiDing self-assigned this Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants