Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization breaks on dynamic changes #150

Open
vneznaikin opened this issue Aug 14, 2022 · 5 comments
Open

Visualization breaks on dynamic changes #150

vneznaikin opened this issue Aug 14, 2022 · 5 comments
Assignees

Comments

@vneznaikin
Copy link

See Codepen example:
https://cdpn.io/gradopetr/fullpage/BarqZjV [Edit: https://codepen.io/gradopetr/pen/BarqZjV]

Browser: Chrome 104.0.5112.81
Audion 3.0.5

If we use a Timeout of 10 seconds, to simulate dynamic changes, the visualization is not collected correctly

temp-2

@braebo
Copy link

braebo commented Aug 27, 2022

I've been struggling with this issue in Brave Browser as well. It seems to create spaghetti once something updates (and I suspect it doesn't properly remove nodes from the graph after they're GC'd).

@TenghuiZhang
Copy link
Collaborator

Hi, @vneznaikin when I am running your code in my local browser, it seems works for me.

The reproduce steps:

  1. Open the page
  2. Left click the browser and click on the "inspect" button
  3. Click the "Web Audio" button in the dev tool to turn on "Audion"
  4. Refresh the page to load all web audio component event
  5. you can see the correct visualization and after 10s the graph changed dynamically.
Dynamic graph change

Please let me know if I miss any steps relate to reproducing this error.

@vneznaikin
Copy link
Author

@TenghuiZhang Yes, your result is correct. But I still get a broken tree. I don't know why.

@TenghuiZhang
Copy link
Collaborator

@vneznaikin Did you refresh your web page after opened Audion extension?

@TenghuiZhang TenghuiZhang self-assigned this Jun 2, 2023
@vneznaikin
Copy link
Author

@TenghuiZhang Of course. The result is consistently repeatable.
Windows 10
Chrome 114.0.5735.90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants