Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth API #133

Open
SixArne opened this issue Apr 29, 2024 · 2 comments
Open

Depth API #133

SixArne opened this issue Apr 29, 2024 · 2 comments

Comments

@SixArne
Copy link

SixArne commented Apr 29, 2024

Hi,

Are there any plans on implementing a depth API for meta devices?

I would love to contribute and help but I have never worked on open source before.
(I do have a very solid knowledge of C++)

I expected to find the Meta Native SDK somewhere in the repository but I couldn't find it.

Regards,

@dsnopek
Copy link
Collaborator

dsnopek commented Apr 29, 2024

We really want to implement the Depth API, and will get around to it eventually, but no one has really started to look into this yet. If you'd like to give it a try, that'd be great!

There's a possibility that this will require making some changes to Godot itself, but there's no way to tell without digging into it.

I expected to find the Meta Native SDK somewhere in the repository but I couldn't find it.

We do include the Meta headers - you can find the header for the necessary OpenXR extension here:

https://github.com/GodotVR/godot_openxr_vendors/blob/master/thirdparty/ovr_openxr_mobile_sdk/OpenXR/Include/openxr/meta_environment_depth.h

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 29, 2024

I've been researching this a tiny bit, and here's some links to resources:

Looking through the sample, it looks like we're expected to change our fragment shader to consult the depth texture that we get from the OpenXR extension. Here's the relevant bit: https://github.com/meta-quest/Meta-OpenXR-SDK/blob/main/Samples/XrSamples/XrPassthroughOcclusion/Src/XrPassthroughOcclusionGl.cpp#L632

In order to make this work, we'll either need to:

  1. Modify Godot so that the builtin shader templates have the ability to do this when given a depth texture, and then allow GDExtension to provide that texture to Godot, or
  2. Require that users modify all of their shaders to do this, and then godot_openxr_vendors just makes this depth texture available for users to do that

Nr 2 could potentially be made easier if Godot allowed users to override Godot's shader templates - see PR godotengine/godot#94427

In any case, this won't be the easiest OpenXR extension to integrate with Godot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants