-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter key on a prompt returns null value #52
Labels
Comments
Can confirm this is still an issue |
I can take a stab at this "bug". Or is this already being fixed somewhere else? @Godofbrowser |
Please help... I've not had time to look at the issue itself to confirm if
its a bug or not so I'm not currently working on it. However, I'd be happy
to merge in a PR if it fixes whatever issue there is with the prompt.
…On Sat, Jun 29, 2019, 9:45 AM Sergej Herbert ***@***.*** wrote:
I can take a stab at this "bug". Or is this already being fixed somewhere
else? @Godofbrowser <https://github.com/Godofbrowser>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#52?email_source=notifications&email_token=AE3FHD7BMKZ6JHHBICPFSA3P44OJ7A5CNFSM4HGPIV3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3UY3I#issuecomment-506940525>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE3FHD2DINOKIPGCABPCV4DP44OJ7ANCNFSM4HGPIV3A>
.
|
@Godofbrowser should I do it in the master branch or the branch "Feature/prompt"? |
Kindly checkout a new branch with descriptive name. Something like
"fix/promt-enter-bug". Thanks alot
…On Sat, Jun 29, 2019, 12:09 PM Sergej Herbert ***@***.*** wrote:
@godofbrowsers should I do it in the master branch or the branch
"Feature/prompt"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#52?email_source=notifications&email_token=AE3FHD3HO2J37EMBDVWS6WLP447HXA5CNFSM4HGPIV3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY3W3TA#issuecomment-506949068>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE3FHD3LJ56TAA26SYK5BLTP447HXANCNFSM4HGPIV3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When pressing the enter key on a prompt dialog, the dialog.data is null.
this.$dialog.prompt({ title: "My Title", body: "Some instructions on what to enter in the prompt." }) .then(dialog => { console.log(dialog); //when clicking the continue button, the dialog.data is what is expected. however, if the enter key is pressed, the dialog is closed, but dialog.data is null })
The text was updated successfully, but these errors were encountered: