track count of multisig sessions opened between two dates

[divine-comedian]

in order to track how often the multisig integration feature is being used we should find a way to track how many multisig sessions were opened between two given dates.

@CarlosQ96 knows where to find this information

[ae2079]

@divine-comedian
After fix the preview by Ramin, now, we can start test it via this link: https://analytics-dashboard-1uj2mh95z-givethio.vercel.app/

[divine-comedian]

@LatifatAbdullahi - here's how to test this issue:

1. create or connect to an existing safe multisig on base sepolia or gnosis chain (those are the only two test networks that both Safe and Giveth support https://app.safe.global/welcome/accounts

I recommend creating a new multisig with 2/2 signers - using two addresses you control, use two separate browsers to connect with each signer (firefox / brave / chrome are all good options)

2. Check on the vercel link to see current # of tracked multisig session connections made https://analytics-dashboard-1uj2mh95z-givethio.vercel.app/

3. Follow these instructions to connect to Giveth with your multisig ---> https://docs.giveth.io/dapps/multisigs
4. When you've connected successfully does the count of sessions go up?
5. repeat steps 1-4 on another chain

[LatifatAbdullahi]

Noted.

[LatifatAbdullahi]

@ae2079

The Dashboard keeps throwing this error

Also, I would like to have a call with you when you are available please before dropping my feedback on the test

[ae2079]

@ae2079

The Dashboard keeps throwing this error

Also, I would like to have a call with you when you are available please before dropping my feedback on the test

I will check this error with @mohammadranjbarz
and I will DM you on Discord to schedule a call

[ae2079]

@ae2079

The Dashboard keeps throwing this error

Also, I would like to have a call with you when you are available please before dropping my feedback on the test

The error is fixed now, you can start your tests with this link:
https://analytics-dashboard-q4j1m7o0a-givethio.vercel.app/

[divine-comedian]

@LatifatAbdullahi - what is the status update of the QA?

[LatifatAbdullahi]

I would have to retest the task to give an update, I had to pause since bugs were still being fixed

[LatifatAbdullahi]

@ae2079
The Dashboard keeps throwing this error

Also, I would like to have a call with you when you are available please before dropping my feedback on the test

The error is fixed now, you can start your tests with this link: https://analytics-dashboard-q4j1m7o0a-givethio.vercel.app/

I missed this comment, thanks I will check

[LatifatAbdullahi]

@divine-comedian @ae2079

Using this link (https://analytics-dashboard-q4j1m7o0a-givethio.vercel.app/), this issue is fixed

Based on this Step " When you've connected successfully does the count of sessions go up? "

Gnosis Chain

Using a safe account created with Gnosis chain and with 2 signers, connecting successfully to the Giveth staging with each signer on chrome and mozilla does not count on the Analytics for Multisig session. The count only reflected when a transaction was done and signed by both signers on separate browsers.

Base Sepolia

Using a safe account created with Base Sepolia and with 2 signers, connecting successfully to the Giveth staging with each signer on chrome and mozilla does not count on the Analytics for Multisig session.

[mateodaza]

@divine-comedian I have a concern that I discussed with @LatifatAbdullahi
I'm not entirely sure how the analytics are working but if they're being tracked on the frontend the fact that the multisig is inside an iframe could cause some unexpected issues.. I would suggest managing this from the authentication microservice in the backend if possible. I'm not sure who set this up to double check

[divine-comedian]

@ae2079 - that's for you, I don't have a strong opinion on what method we use to track the information, as long as it is reliable..

And to clarify from Latifat's testing - we should be tracking the moment from when a multisig session is opened - not from when a transaction is made from a multisig.

[ae2079]

@divine-comedian I have a concern that I discussed with @LatifatAbdullahi I'm not entirely sure how the analytics are working but if they're being tracked on the frontend the fact that the multisig is inside an iframe could cause some unexpected issues.. I would suggest managing this from the authentication microservice in the backend if possible. I'm not sure who set this up to double check

yes, I use swieAuthMicroservice for that, and I get the data from multisigSessions repository

[ae2079]

@ae2079 - that's for you, I don't have a strong opinion on what method we use to track the information, as long as it is reliable..

And to clarify from Latifat's testing - we should be tracking the moment from when a multisig session is opened - not from when a transaction is made from a multisig.

Based on the implementation, it seems there are no dependencies with donations, but I will double-check it and test it.
How can I create a multisig session on staging? @divine-comedian

[ae2079]

@mateodaza it seems the login issue still exists on the staging because I tried many times to sign messages in the safe wallet and after a while it didn't apply to the staging app and I am still not logged in.

I gave this query from @CarlosQ96 to create a multisig session manually on the database:

INSERT INTO public.multisig_session
("safeMessageHash", "multisigAddress", "expirationDate", "createdAt", "updatedAt", "approvalExpirationDate", active, network, status)
VALUES
('0x249639e0af0157c3a53ef27565f2a6a26011ea46003b0605d8035f7516e6fefb', -- safeMessageHash
 '0x40891ce6e8574bb9118913a8a304195437f36213', -- multisigAddress
 CURRENT_DATE + INTERVAL '3 months', -- expirationDate
 CURRENT_DATE, -- createdAt
 CURRENT_DATE, -- updatedAt
 CURRENT_DATE + INTERVAL '3 months', -- approvalExpirationDate
 TRUE, -- active
 10, -- network
 'successful' -- status
);

and after executing this query, the amount of multisig sessions increased correctly:

@LatifatAbdullahi I think the problem may be related to multisig sessions issue on the staging because the metrics increased for me without making any donation.

@divine-comedian For releasing this feature, we need to deploy changes on the swieAuth microservice first, and these changes did not affect other features so we can deploy them independently.

[mateodaza]

@mateodaza it seems the login issue still exists on the staging because I tried many times to sign messages in the safe wallet and after a while it didn't apply to the staging app and I am still not logged in.

I gave this query from @CarlosQ96 to create a multisig session manually on the database:

INSERT INTO public.multisig_session

("safeMessageHash", "multisigAddress", "expirationDate", "createdAt", "updatedAt", "approvalExpirationDate", active, network, status)

VALUES

('0x249639e0af0157c3a53ef27565f2a6a26011ea46003b0605d8035f7516e6fefb', -- safeMessageHash

 '0x40891ce6e8574bb9118913a8a304195437f36213', -- multisigAddress

 CURRENT_DATE + INTERVAL '3 months', -- expirationDate

 CURRENT_DATE, -- createdAt

 CURRENT_DATE, -- updatedAt

 CURRENT_DATE + INTERVAL '3 months', -- approvalExpirationDate

 TRUE, -- active

 10, -- network

 'successful' -- status

);

and after executing this query, the amount of multisig sessions increased correctly:

@LatifatAbdullahi I think the problem may be related to multisig sessions issue on the staging because the metrics increased for me without making any donation.

@divine-comedian For releasing this feature, we need to deploy changes on the swieAuth microservice first, and these changes did not affect other features so we can deploy them independently.

You still need to sign with your signer address every single time, according to your screenshot you still miss that step

[ae2079]

@mateodaza I checked the multisig_sessions table and there was no entry for my multisig wallet address and also checked the code and saw there is no config for network ID that relates to base sepolia network, maybe this can help you to find the issue

[ae2079]

@mateodaza it seems the login issue still exists on the staging because I tried many times to sign messages in the safe wallet and after a while it didn't apply to the staging app and I am still not logged in.


I gave this query from @CarlosQ96 to create a multisig session manually on the database:

INSERT INTO public.multisig_session

("safeMessageHash", "multisigAddress", "expirationDate", "createdAt", "updatedAt", "approvalExpirationDate", active, network, status)

VALUES

('0x249639e0af0157c3a53ef27565f2a6a26011ea46003b0605d8035f7516e6fefb', -- safeMessageHash

 '0x40891ce6e8574bb9118913a8a304195437f36213', -- multisigAddress

 CURRENT_DATE + INTERVAL '3 months', -- expirationDate

 CURRENT_DATE, -- createdAt

 CURRENT_DATE, -- updatedAt

 CURRENT_DATE + INTERVAL '3 months', -- approvalExpirationDate

 TRUE, -- active

 10, -- network

 'successful' -- status

);

and after executing this query, the amount of multisig sessions increased correctly:

@LatifatAbdullahi I think the problem may be related to multisig sessions issue on the staging because the metrics increased for me without making any donation.
@divine-comedian For releasing this feature, we need to deploy changes on the swieAuth microservice first, and these changes did not affect other features so we can deploy them independently.

You still need to sign with your signer address every single time, according to your screenshot you still miss that step

I think I do that, let me do it again to ensure that

[ae2079]

first I open the app from the safe wallet webpage, then I click on my MyAccount, and this pop-up is shown:

then I click on sign in button and select a 1 week duration for example:

after clicking on 'let's do it' button, I have to sign this message with my Metamask wallet:

after that, I redirected to the safe message signing page and signed it with my Metamast again:

after signing it, I was redirected to this page again:

and after that, when I closed the pop-up and selected myAccount again, I faced this pop-up again (without reloading the page):

@mateodaza if I missed any steps, let me know what should I exactly do, thanks

[mateodaza]

first I open the app from the safe wallet webpage, then I click on my MyAccount, and this pop-up is shown:

then I click on sign in button and select a 1 week duration for example:

after clicking on 'let's do it' button, I have to sign this message with my Metamask wallet:

after that, I redirected to the safe message signing page and signed it with my Metamast again:

after signing it, I was redirected to this page again:

and after that, when I closed the pop-up and selected myAccount again, I faced this pop-up again (without reloading the page):

@mateodaza if I missed any steps, let me know what should I exactly do, thanks

Can you please test it with a multisig of 2 signers at least? - there's an edge case for 1 signer multisigs that we haven't tackled yet

[ae2079]

first I open the app from the safe wallet webpage, then I click on my MyAccount, and this pop-up is shown:

then I click on sign in button and select a 1 week duration for example:

after clicking on 'let's do it' button, I have to sign this message with my Metamask wallet:

after that, I redirected to the safe message signing page and signed it with my Metamast again:


after signing it, I was redirected to this page again:

and after that, when I closed the pop-up and selected myAccount again, I faced this pop-up again (without reloading the page):

@mateodaza if I missed any steps, let me know what should I exactly do, thanks

Can you please test it with a multisig of 2 signers at least? - there's an edge case for 1 signer multisigs that we haven't tackled yet

Oh, ok, I'll do that

[ae2079]

@LatifatAbdullahi
I signed in using a safe account with two signers in the gnosis chain and without any donations, the metric increased:

I tried to create a new safe wallet with two singers on base sepolia, but it seems there are some issues(maybe because it is a test net) with the help of @mateodaza, I created a wallet and tested on the gnosis chain

FYI @divine-comedian

[ae2079]

@divine-comedian
I created two branches for releasing this feature when you approved it:
for the back-end: Giveth/SiweAuthMicroservice#29 (I think @CarlosQ96 should deploy this service)
for the front-end: #23 (we should merge it after the backend deployed)

[divine-comedian]

looks like this all merged on production! great