Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: wrong manual backport message (not always) #94

Open
wolfogre opened this issue Jul 7, 2023 · 5 comments
Open

Bug: wrong manual backport message (not always) #94

wolfogre opened this issue Jul 7, 2023 · 5 comments

Comments

@wolfogre
Copy link

wolfogre commented Jul 7, 2023

go-gitea/gitea#25721 (comment)

@yardenshoham
Copy link
Collaborator

Yes, the bot uses labels for state, and seeing as we only have one backport/done label the bot doesn't add it if a PR has more than one backport/v1.* labels. I want to keep the bot stateless, so this is the situation. If we had backport/v1.*-done labels we could maintain state in the labels.

@KN4CK3R
Copy link

KN4CK3R commented Apr 4, 2024

Can't you check the reason if cherry picking fails to check if all backports are done?

@yardenshoham
Copy link
Collaborator

Currently we simply log the stdout and stderr of the git cherry-pick

@KN4CK3R
Copy link

KN4CK3R commented Apr 4, 2024

Yes, but doesn't the output give a clue why it failed which can be used by the bot?

@yardenshoham
Copy link
Collaborator

Possibly, usually it lists the conflicted files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants