New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect milestone #112

Open

yp05327 opened this issue Dec 11, 2023 · 1 comment

yp05327 commented Dec 11, 2023 •

edited

Loading

I think this is caused by that v1.19 does not support any more, so bot can not find the correct milestone.
Maybe we can add a check of this in L14:

gitea-backporter/src/milestones.ts

Lines 10 to 14 in 4dc4c52

    
           // find the gitea version that matches the PR's base branch 
        
           let giteaVersion = giteaVersions.find((version) => 
        
             pr.base.ref === `release/v${version.majorMinorVersion}` 
        
           );

yp05327 changed the title ~~Incorrect minestrone~~ Incorrect milestone

Collaborator

yardenshoham commented Dec 11, 2023

Is it correct to open a PR to release/v1.19 if there will not be a v1.19 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment