Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottle data tags are urls #455

Merged
merged 9 commits into from
Nov 1, 2024
Merged

bottle data tags are urls #455

merged 9 commits into from
Nov 1, 2024

Conversation

giannif
Copy link
Collaborator

@giannif giannif commented Oct 31, 2024

bottle data tags are urls not markup

Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: 43c2969

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@giphy/react-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@gpadin-cp gpadin-cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image


return <div ref={elRef} dangerouslySetInnerHTML={{ __html: markup }}></div>
function BottleData({ src }: { src: string }) {
return <img src={processTag(src)} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO CLEAN!

@giannif giannif merged commit 2a05915 into master Nov 1, 2024
1 check passed
@giannif giannif deleted the bottle-data-fix-2 branch November 1, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants