Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternatives for --force-login #64

Open
GijsTimmers opened this issue Feb 8, 2015 · 2 comments
Open

Alternatives for --force-login #64

GijsTimmers opened this issue Feb 8, 2015 · 2 comments

Comments

@GijsTimmers
Copy link
Owner

See this image:

schermafdruk van 2015-02-08 22 29 57

This makes --force-login useless.

@GijsTimmers GijsTimmers self-assigned this Feb 8, 2015
@GijsTimmers GijsTimmers added this to the 2.0.0 milestone Feb 8, 2015
@GijsTimmers
Copy link
Owner Author

I've just checked. The maximum number of IPs at the moment is 2. That means that
there's still a use for --force-login or a derivative.

We need to decide, what IP should be logged out, though. Some ideas:

  • Change --force-login behaviour: always log out all logged in IP addresses
  • --force-login gets deprecated; if the maximum number of IPs is reached, --login will exit with an error code and show the currently logged in IP's. The user can then enter one of the following commands:
    • --logout-oldest: logout of the oldest obtained IP
    • --logout-latest: logout of the latest obtained IP
    • --logout:
      • --logout 10.92.32.43 logs out IP 10.92.32.43
      • --logout here logs out the current IP.
      • --logout logs out the current IP (if possible)

This change in Kotnet policy is great for users, but doesn't really come in handy for the project. We'll have to reconsider the project's design and roadmap.

@jovanbulck
Copy link
Collaborator

Yep indeed

I propose temporarily omitting the force-login option and currently focus on logging in/out with the current design in mind. As the implementation is currently upside down, getting the key features --login and --logout stable should be our core concern now, I think. Ommiting force-login for now will easy things somehow and allow a better integration in the end I think.

Adding some of the options you mentioned above should then be incorporated in the v3.0.0 roadmap. If so, we should change the label of this issue accordingly...

@jovanbulck jovanbulck modified the milestones: 3.0.0, 2.0.0 Feb 11, 2015
@jovanbulck jovanbulck changed the title Kotnet now allows multiple IP addresses per account. This renders --force-login useless. Alternatives for --force-login Feb 11, 2015
@jovanbulck jovanbulck added @low and removed @high labels Feb 11, 2015
jovanbulck added a commit that referenced this issue Feb 11, 2015
…ussed in issue #64 and commented out some communicators for readability and some fixes to make it work more or less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants