Potential Race Condition on Semaphoring Switcher Protocol

[kory33]

The protocol described here

BungeeSemaphore/src/main/scala/click/seichi/bungeesemaphore/infrastructure/bugeecord/listeners/SemaphoringServerSwitcher.scala

Lines 36 to 45 in bcd5886

	* | ===[2]===> | | |
	* | | | |
	* | "data being saved" |
	* | ==============[3]==============> |
	* | | | |
	* | [Saves data] | |
	* [holds p's ] [associated] | |
	* [connection] [ with p ] | |
	* | | "data saved" |
	* | | >>>>>>>[4]>>>>>>> |

potentially introduces a race condition because BungeeCord plugin (this is us) may initiate the Redis request after Spigot plugin has reported to Redis the completion of the data persistence (although this is very unlikely).

We can avoid this problem by having the "step 3" done before "step 2", since Redis then serializes write requests in the desired order.

[kory33]

Actually, the issue does not exist. Implementation is entirely correct, and it is just the documentation having the sequence diagram wrong.