Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity needs units and fuzzy support #466

Open
cwyse opened this issue Mar 25, 2020 · 7 comments
Open

Quantity needs units and fuzzy support #466

cwyse opened this issue Mar 25, 2020 · 7 comments
Labels

Comments

@cwyse
Copy link

cwyse commented Mar 25, 2020

Especially for seeds, when I need to enter a quantity for an accession, I'm not sure of the exact number. Maybe I got 1 gram of seeds. Maybe I have a handle of seeds, and I think I have about 100 seeds. I'd like to have an option to enter units and a way to indicate an inexact amount.

@mfrasca mfrasca added discussion still undecided need-info labels Mar 26, 2020
@mfrasca
Copy link
Member

mfrasca commented Mar 26, 2020

@RoDuth, IIRC you had this problem in Australia, I don't remember how you solved it. by adapting your practice, by altering the software locally, you want to remind me and tell @cwyse ?

@RoDuth
Copy link
Contributor

RoDuth commented Mar 27, 2020

We had originally been using things like '30+' which were allowed with sqlite but when trying to import into postgresql this failed. We then realised that if we knew the exact amount it was almost never multiples of 10 like this so we just started using multiples of 10 as a convention for estimated numbers (be they clumps, hedges, border plantings, etc.) and including a note, something like type: "quantity" note: "hedge". On the odd occasion it was actually 10 and not an estimate it was easy to see there was no note.

On a side note I have been looking at our seed bank records (currently not in Ghini) and we have a fairly strict way to come up with numbers (basically, count out a portion and compare the weight to the whole) and they are the same, almost never multiples of 10.

In your situation you could include a note, something like type: "accuracy" note: "+/-20" I guess?

@mfrasca
Copy link
Member

mfrasca commented Apr 7, 2020

@cwyse , as you see, it's a bit adapting to the limitations in the software, and it's good that you mention what you miss, so we can add it in a future version.
The reason why I did not add it to 1.0, it's very simple: it would mean a change in the database structure, and in ghini.desktop a database structure corresponds to a software version.
in ghini-reloaded it's possible to add it in the same version, because django has built-in migrations.

@cwyse
Copy link
Author

cwyse commented Apr 8, 2020

Thank you both for responding. @RoDuth had the exact same problem that I did, and implemented basically the same solution.

My thought was that adding two columns to the database would address the problem. One column for the units, and one column indicating accuracy. Probably oversimplifying, but I'm guessing that the column addition (instead of removing, changing, or adding a new table) would maintain compatibility with older versions.

Anyway, it's a low priority item for me.

@mfrasca
Copy link
Member

mfrasca commented Apr 8, 2020 via email

@cwyse
Copy link
Author

cwyse commented Apr 25, 2020

Definitely should have a database version. I defer to you on how complex the problem is - I haven't gone through the code base. It was a suggestion, but the cost/benefit ratio may not merit working on it. Thanks for looking at it.

@cwyse cwyse closed this as completed Apr 25, 2020
@mfrasca
Copy link
Member

mfrasca commented May 1, 2020

I'll re-open this one, because it's not solved, and it could be better documented too.

@mfrasca mfrasca reopened this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants