Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO in the code (species.py) #451

Open
mfrasca opened this issue Oct 15, 2018 · 0 comments
Open

TODO in the code (species.py) #451

mfrasca opened this issue Oct 15, 2018 · 0 comments
Labels
chore has to happen ghini-3.1 question if unsure, use this label

Comments

@mfrasca
Copy link
Member

mfrasca commented Oct 15, 2018

As a forgeful programmer, I want to keep things centralized, and I do not wnt todo hanging in the code, that really are issues to be examined.

Actual behaviour

just removed from species.py:

# TODO: we need to make sure that this will still work if the
# AccessionPlugin is not present, this means that we would have to
# change the species context menu, getting the children from the
# search view and what else

there isn't anything like an AccessionPlugin, unless one means the GardenPlugin. but why do we need to worry about it not being present?

@mfrasca mfrasca added question if unsure, use this label ghini-3.1 chore has to happen labels Oct 15, 2018
mfrasca added a commit that referenced this issue Oct 15, 2018
mfrasca added a commit that referenced this issue Dec 2, 2018
this is stated in a TODO line, and in the individual empty test functions.
mfrasca added a commit that referenced this issue Dec 2, 2018
this is stated in a TODO line, and in the individual empty test functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore has to happen ghini-3.1 question if unsure, use this label
Projects
None yet
Development

No branches or pull requests

1 participant