Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]Allow callSettings propagation to CallState #497

Merged
merged 4 commits into from
Aug 29, 2024
Merged

[Fix]Allow callSettings propagation to CallState #497

merged 4 commits into from
Aug 29, 2024

Conversation

ipavlidakis
Copy link
Collaborator

🎯 Goal

Allow providing initial callSettings when starting a call (and skipping joining).

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Aug 28, 2024
@ipavlidakis ipavlidakis self-assigned this Aug 28, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner August 28, 2024 15:05
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Aug 28, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.4 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.32 MB 2.32 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@github-actions GitHub Actions
Copy link

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
33 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.0% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

@ipavlidakis ipavlidakis enabled auto-merge (squash) August 29, 2024 12:01
@ipavlidakis ipavlidakis merged commit fbfa582 into develop Aug 29, 2024
13 checks passed
@ipavlidakis ipavlidakis deleted the fix/callsettings-override-when-starting-call branch August 29, 2024 12:06
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski