Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Only reuse VideoRenderers when they are actually presented #263

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[Fix]Only reuse VideoRenderers when they are actually presented #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/StreamVideoSwiftUI/CallView/VideoParticipantsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,8 @@ public struct VideoCallParticipantView: View {
var customData: [String: RawJSON]
var call: Call?

@State private var isVisible = false

public init(
participant: CallParticipant,
id: String? = nil,
Expand All @@ -350,7 +352,7 @@ public struct VideoCallParticipantView: View {
id: id,
size: availableFrame.size,
contentMode: contentMode,
showVideo: showVideo,
showVideo: showVideo && isVisible,
handleRendering: { [weak call] view in
guard call != nil else { return }
view.handleViewRendering(for: participant) { size, participant in
Expand All @@ -360,6 +362,8 @@ public struct VideoCallParticipantView: View {
}
}
)
.onAppear { isVisible = true }
.onDisappear { isVisible = false }
.opacity(showVideo ? 1 : 0)
.edgesIgnoringSafeArea(edgesIgnoringSafeArea)
.accessibility(identifier: "callParticipantView")
Expand Down
Loading