Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Only reuse VideoRenderers when they are actually presented #263

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ipavlidakis
Copy link
Collaborator

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Jan 16, 2024
@ipavlidakis ipavlidakis self-assigned this Jan 16, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner January 16, 2024 16:35
@ipavlidakis ipavlidakis mentioned this pull request Jan 16, 2024
7 tasks
@ipavlidakis ipavlidakis merged commit 9a414a2 into main Jan 17, 2024
10 of 11 checks passed
@ipavlidakis ipavlidakis deleted the fix/missing-local-track branch January 17, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants