Improved InternetConnection.Monitor stability #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
ipavlidakis
reviewed
Dec 21, 2023
| @@ -168,7 +169,7 @@ extension InternetConnection { | |||
| guard monitor == nil else { return } | |||
|
|
|||
| monitor = createMonitor() | |||
| monitor?.start(queue: .global()) | |||
| monitor?.start(queue: queue) | |||
There was a problem hiding this comment.
Would it make more sense to use a global queue with a qos of .background or .utility?
There was a problem hiding this comment.
I would prefer to keep it like this, since this was already tested on the chat monitor on older iOS 14/15 versions.
ipavlidakis
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Same fix as in the chat client: https://github.com/GetStream/stream-chat-swift/pull/2923/files.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
imgimg🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)