Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvements]Change available size to available frame #176

Merged
merged 7 commits into from
Oct 6, 2023
Merged

[Improvements]Change available size to available frame #176

merged 7 commits into from
Oct 6, 2023

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Oct 6, 2023 •
edited
Loading

🎯 Goal

Refactor and change availableSize: CGSize to availableFrame: CGRect in most Views, in order to provider better visibility functionality in order to reduce CPU usage when views aren't fully visible.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 6, 2023
@ipavlidakis ipavlidakis self-assigned this Oct 6, 2023
@ipavlidakis ipavlidakis requested a review from a team as a code owner October 6, 2023 10:34
@ipavlidakis ipavlidakis mentioned this pull request Oct 6, 2023
Merged
7 tasks
@ipavlidakis ipavlidakis changed the title Improvements/change available size to available frame [Improvements]Change available size to available frame Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

1 Error
🚫 Please use more than one word.
4cfcf5c
1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@ipavlidakis ipavlidakis changed the base branch from main to improvements/visibility-observation-for-video-track-views October 6, 2023 10:40
@ipavlidakis ipavlidakis force-pushed the improvements/visibility-observation-for-video-track-views branch 2 times, most recently from 04371c5 to a423ee4 Compare October 6, 2023 13:30
martinmitrevski
martinmitrevski reviewed Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one nit. Also, it seems like you pulled other stuff as well, and there are conflicts.

docusaurus/docs/iOS/03-guides/10-view-slots.mdx Outdated Show resolved Hide resolved
@ipavlidakis ipavlidakis force-pushed the improvements/change-availableSize-to-availableFrame branch from 12861a3 to 5bc1e6f Compare October 6, 2023 14:32
@ipavlidakis ipavlidakis force-pushed the improvements/change-availableSize-to-availableFrame branch from 5bc1e6f to fdb8ac9 Compare October 6, 2023 14:33
@ipavlidakis
Copy link
Collaborator Author

lgtm, just one nit. Also, it seems like you pulled other stuff as well, and there are conflicts.

The conflicts were because the parent branch which isn't main had some conflicts too.

@ipavlidakis ipavlidakis merged commit ab38e14 into improvements/visibility-observation-for-video-track-views Oct 6, 2023
8 checks passed
@ipavlidakis ipavlidakis deleted the improvements/change-availableSize-to-availableFrame branch October 6, 2023 15:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.9% 71.9% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipavlidakis @martinmitrevski