Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]Sorting comparators for fullscreen layout and PiP #613

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[Fix]Sorting comparators for fullscreen layout and PiP #613

merged 2 commits into from
Dec 3, 2024

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

Resolves IOS-499

📝 Summary

The revision fixes an issue where the dominant speaker doesn't become the visible track when changing, in fullscreen layout and PictureInPicture.

🧪 Manual Testing Notes

  • Join a call with 2 other participants
  • Either change the layout to fullscreen or move to the background (in order to active PiP)
  • Make the other users talk in order to change the dominant speaker
  • The dominant participant should be visible (and changing) in every case

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Dec 3, 2024
@ipavlidakis ipavlidakis self-assigned this Dec 3, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner December 3, 2024 09:29
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 3, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.61 MB 7.61 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

martinmitrevski
martinmitrevski approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
126 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis enabled auto-merge (squash) December 3, 2024 09:56
@ipavlidakis ipavlidakis merged commit 3dfc2e2 into develop Dec 3, 2024
14 checks passed
@ipavlidakis ipavlidakis deleted the fix/ios-497-video-there-is-no-ios-track-after-coming-back-to-the branch December 3, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski