Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Report join call telemetry #612

Merged
merged 3 commits into from
Dec 3, 2024
Merged

[Feature]Report join call telemetry #612

merged 3 commits into from
Dec 3, 2024
+211 −5

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Dec 2, 2024 •
edited
Loading

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-585/report-connection-times-to-the-sfu

🎯 Goal

Report join call telemetry including join strategy and duration. (React reference PR)

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Dec 2, 2024
@ipavlidakis ipavlidakis self-assigned this Dec 2, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner December 2, 2024 17:49
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 2, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.61 MB 7.61 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis enabled auto-merge (squash) December 2, 2024 19:00
martinmitrevski
martinmitrevski reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite easy to do with the current setup we have 😄 Left just one small comment, let me know what you think.

Sources/StreamVideo/WebRTC/v2/StateMachine/Stages/WebRTCCoordinator+Joining.swift Outdated Show resolved Hide resolved
@martinmitrevski
Copy link
Collaborator

Tests are failing now, probably need to be updated to take into consideration the change we did.

@ipavlidakis
Copy link
Collaborator Author

Oops :D

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
126 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis merged commit 850a602 into develop Dec 3, 2024
14 checks passed
@ipavlidakis ipavlidakis deleted the feature/connection-telemetry branch December 3, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski