[Improvement]SpeakerManager callSettings observation #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
ipavlidakis
force-pushed
the
improvement/speaker-manager-callSettings-observation
branch
from
0671dd4 to
150b9f1
Compare
|
martinmitrevski
approved these changes
Nov 4, 2024
ipavlidakis
deleted the
improvement/speaker-manager-callSettings-observation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This revision provides a connecting mechanism that allows a Call's CallSettings observation from SpeakerManager. That will important, in order to allow the SpeakerManager to be updated with speaker/AudioSession updates that haven't been initiated from the SDK's components(e.g. CallKit, Bluetooth headphones connected etc.)
☑️ Contributor Checklist