[Fix]Failing tests #509
Merged
[Fix]Failing tests #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
martinmitrevski
approved these changes
Sep 4, 2024
| @@ -8,89 +8,89 @@ import XCTest | |||
|
|
|||
| final class SFUMiddleware_Tests: XCTestCase, @unchecked Sendable { | |||
|
|
|||
| private var mockSFUService: MockSignalServer! | |||
There was a problem hiding this comment.
shouldn't we just delete this file?
There was a problem hiding this comment.
We will end up removing it, but before doing i would like to write the tests for the new SFUEventAdapter and ensure that all the cases in this file, will be covered in the new tests.
SDK Size
|
|
ipavlidakis
added a commit
that referenced
this pull request
Sep 4, 2024
ipavlidakis
added a commit
that referenced
this pull request
Sep 9, 2024
ipavlidakis
added a commit
that referenced
this pull request
Sep 18, 2024
ipavlidakis
added a commit
that referenced
this pull request
Sep 19, 2024
ipavlidakis
added a commit
that referenced
this pull request
Sep 24, 2024
ipavlidakis
added a commit
that referenced
this pull request
Sep 24, 2024
ipavlidakis
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This revision tries to bring most of Tests back online in order to provide status visibility on the reconnection-v2 branch.