Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]CallSettings propagation to call #505

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[Fix]CallSettings propagation to call #505

merged 1 commit into from
Sep 3, 2024

Conversation

ipavlidakis
Copy link
Collaborator

📝 Summary

This revision allows configuring a Call's initial mic, camera and speaker settings by respecting the provided CallSettings.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Sep 3, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 3, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner September 3, 2024 12:38
@ipavlidakis ipavlidakis changed the title [Fix]CalSettings propagation to call [Fix]CallSettings propagation to call Sep 3, 2024
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.4 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.32 MB 2.32 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
36 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.8% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

@ipavlidakis ipavlidakis merged commit 17fbf0f into develop Sep 3, 2024
13 checks passed
@ipavlidakis ipavlidakis deleted the fix/callsettings-propagation-to-call branch September 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski