Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhealth host count alert is not working, because it doesn't have target group dimension #40

Open
sannithibalaji opened this issue Jun 30, 2020 · 0 comments

Comments

@sannithibalaji
Copy link

target group dimension is required for finding the number of unhealthy host, it is not present so unhealthy host alarm is not working.

jeechu pushed a commit to jeechu/cloudlift that referenced this issue Mar 15, 2021
* implement secrets_manager#get_config

* deployer.build_config to return the env list as dict list

* add test coverage for ecs.TaskDefinition.apply_container_environment

* change deployment time env change to env config format

* modify service template generator to new format of env config

* refactor config validation

* return ARN with version for secret values from secrets_manager.get_config

* mondify build_config to pull and merge configs from both secrets manager and param store

* handle error in dummy app to show rest of the env vars

* change build_config to return secrets and environment separately

* modify deployment to work with new config structure

* modify service template generation to include secrets and env

* bump version

* introduce secrets_config_prefix in service config and use in service creation

* pass secrets_config_prefix during deployment

* create task execution role as part of service creation

* add secrets name prefix to output

* fix the arn for versioned secret

* fix task execution role to have same permissions as AmazonECSTaskExecutionRolePolicy

* fix deployment (env & secret diff, taskExecutionRole in register task defn)

* fix version returning master if dirty. This cause update_service to hang during development when we have services deployed with dirty images. Since master is not available, the ECS service will not stabilize and the cfn update will hang

* test cover service information fetcher and cleanup service updater

* add TODO to cleanup ServiceInformationFetcher.fetch_current_desired_count

* minor fixes

* refactor test_cloudlift

* add test for service with secrets manager config

* fix relative paths in tests

* specify the exact secret name in task execution role

* cache fetching from secrets manager

* fix test

* Add ability to specify env.sample as flag

* Remove logs when using cache

* Remove prompt for env_sample_file

Co-authored-by: Aswin Karthik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant