Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximum number of Caring Circles to 1 per user (default) #90

Closed
4 tasks
brylie opened this issue Sep 28, 2022 · 5 comments · May be fixed by #169
Closed
4 tasks

Limit maximum number of Caring Circles to 1 per user (default) #90

brylie opened this issue Sep 28, 2022 · 5 comments · May be fixed by #169
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Tasks suitable for Hacktoberfest help wanted Extra attention is needed

Comments

@brylie
Copy link
Member

brylie commented Sep 28, 2022

In preparation for a tiered service offering, we will limit the maximum number of Caring Circles to 1 per user.

Acceptance criteria

  • users can only create one Circle
    if a user has created a Circle:
  • the "create circle" button will not be displayed on the Circles page
  • the "create circle" view will redirect to a friendly page explaining the one Circle limit
  • any related UI texts will be internationalized
@brylie brylie added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Tasks suitable for Hacktoberfest labels Sep 28, 2022
@werberger
Copy link
Contributor

Can I be assigned this one @brylie ?

@werberger
Copy link
Contributor

Given I'm fairly inexperienced @brylie, would you prefer I discuss my proposed solution or simply create my PR?

@brylie
Copy link
Member Author

brylie commented Dec 5, 2022

@werberger, good question. I omitted the "acceptance criteria" from the issue description.

However, given the project plans ti develop REST API, would you like to start on the user login/logout API views, using Django REST Framework instead of this issue?

@brylie
Copy link
Member Author

brylie commented Dec 6, 2022

I'll close this issue for now. The idea was to find a sustainable business model for this project by introducing artificial scarcity. It will be more natural perhaps to ask for voluntary financial support or to offer a premium feature that involves actual scarcity, such as significant compute time/storage.

Granted, development time is limited, so we will hopefully figure out sustainable revenue soon.

@brylie brylie closed this as completed Dec 6, 2022
@werberger
Copy link
Contributor

Your added Acceptance Criteria clarifies that you were only talking about creating a new circle not joining. However, I seems to me like that's already the case as commented in circles\views.py

Am I misunderstanding something?

    def test_func(self) -> bool:
        """
        For now, users can only create at most one Circle (a.k.a. care circle)

        The limit is intended to reduce the liklihood of abuse while eventually
        encouraging users to become supporters when that tier becomes available.

        Here, we check whether a user is already a care circle organizer. If so,
        they cannot add a new Circle (care circle).
        """

        return not self.request.user.is_care_circle_organizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Tasks suitable for Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants