Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance : don't wait for tile persistence to send tile to request initiator #1200

Open
AlexGacon opened this issue Dec 5, 2023 · 7 comments

Comments

@AlexGacon
Copy link

Hi,

Would-it be possible to add an option in geowebcache to have the tile persistence done asynchronously from the reply of the request. Like this, the caller can directly have the tile without waiting for the storage, if the storage has performance issues.

@aaime
Copy link
Member

aaime commented Dec 5, 2023

Oh, this has been on my want-list for years now. Yes. Just find someone with time to code it.

@AlexGacon
Copy link
Author

Isn't it enough to call the method on this line asynchronously ?

@aaime
Copy link
Member

aaime commented Dec 11, 2023

For the simple non meta-tiling case, the lock must be released once the file is written on disk, so that other threads find it and avoid computation. But the meta-tiling case needs to be taken care of as well, and that's more complicated, we might need two levels of locks, one for the meta-tile (block until computed), and one for each single tile (block until saved), with the single tile one released asynchronously.

@aaime
Copy link
Member

aaime commented May 13, 2024

This PR does exactly what's requested here (among other things), but it's targeting the GeoServer integration case only.

Some of the same code could be made more general and ported over to standalone GWC, eventually.

@AlexGacon
Copy link
Author

Hi Andrea. Thank you for the update.

@aaime
Copy link
Member

aaime commented Nov 4, 2024

That PR has been merged. However, it only affects a GWC embedded in GeoServer, not a stand-alone GWC talking to a WMS server via HTTP. Is that enough for you @AlexGacon ?

@AlexGacon
Copy link
Author

Hi Andrea. I will see with Gabriel if it is enough for the GS Cloud case I have in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants