Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic for when to write output files needs improving #438

Open
chris-simpson opened this issue Jun 15, 2023 · 0 comments
Open

Logic for when to write output files needs improving #438

chris-simpson opened this issue Jun 15, 2023 · 0 comments

Comments

@chris-simpson
Copy link
Contributor

When a recipe has been completed, there is logic to determine whether to write the output files to disk. This is meant to be decided based on whether the outputs are different from the inputs (to avoid writing when the display() primitive is run as a recipe). This logic is insufficient as, for example, it doesn't work on the GHOSTDR findApertures() primitive, which leaves the data alone but appends extensions.

One obviously can't keep full copies of the inputs in memory for comparison with the outputs but we need to do better. Maybe save the headers for comparison?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant