-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to V2 Addon #158
base: master
Are you sure you want to change the base?
Convert to V2 Addon #158
Conversation
@NullVoxPopuli Hi! |
Great stuff @NullVoxPopuli! (as always). Do you remember what was wrong with this PR? The "CI / Build tests" job was failing but the artifacts are no longer available. What is the work needed to push it through? |
Yeah, i was having an issue with tests using apis that don't exist in the browser that were polyfilled by webpack4 |
We already require ember-auto-import@v2 so when this PR is complete, it would have been a non-breaking change -- however, I also dropped support / testing for ember-source <
3.28
for some sanity reasons. Previously 3.25 was tested against, but it wasn't until 3.27 that ember-source started shipping regular ESM. The differences are minor, but can surface issues in weird ways -- I mostly don't want to deal old code so.. here we have 3.28 as the minimum version now 🙃How we got here (in order)
How do you review something like this? (It's still a big PR)
Points of interest:
Things to keep in mind