Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zauber Cauldrons: Zauber Armor generic.armor does not stack properly with other custom armor attributes #977

Open
EpyonProjects opened this issue Feb 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@EpyonProjects
Copy link
Member

Describe the bug
Zauber Cauldrons copies existing armor attributes then adds its own custom copy of attributes, adding its own modified minecraft:generic.armor , potentially causing a much higher armor value than expected

To Reproduce
Steps to reproduce the behavior:

  1. Obtain armor that recreates the vanilla armor attributes (like Combat Expanded armor)
  2. Convert into Zauber Armor with the armor bonus
  3. Get Zauber Armor with duplicated vanilla armor amount

Expected behavior
Zauber should not add vanilla armor amount more than once

Fix

  1. Vanilla attributes have default UUID values for every attribute. When recreating the vanilla values, you should use this (without modifying)
  2. Zauber should add its own custom attribute rather than modifying the vanilla value (I know it adds another lore line, deal with it :P)

Screenshots
image

Environment

  • Minecraft version: 1.20.4
  • Server version: Public Server 10
  • Installed Datapacks: All, but most importantly Combat Expanded and Zauber Cauldrons
  • Installed Mods: None

Additional context
Have fun updating CE And ZC :)
Each equipment slot has a separate vanilla UUID. Attributes apply onto the player, so you can't have duplicates. Good luck

@EpyonProjects EpyonProjects added the bug Something isn't working label Feb 28, 2024
@Bloo-dev Bloo-dev self-assigned this Feb 28, 2024
@Bloo-dev
Copy link
Member

For clarification, CE will also need adjsuting; the core issue here is that both CE and ZC have been dealing with vanilla attributes slightly wrongly, generating a vanilla attribute with a random UUID where the UUID should be fixed per attribute-slot combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants