Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Pipeline Generates Broken init.mcfunction Files for Old Minecraft Versions #1066

Open
Bloo-dev opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working tool This is related to our build pipeline

Comments

@Bloo-dev
Copy link
Member

Bloo-dev commented Nov 5, 2024

Describe the bug
The init.mcfunction of modules downloaded for old versions (tested for 1.14) are not able to be installed as the init.mcfunction contains malformed mcfunction code.

To Reproduce
Steps to reproduce the behavior:

  1. Download Liquid Tanks for 1.14
  2. Create a new 1.14 world and put the module in the datapacks folder
  3. Run /reload
  4. Observe how Gamemode 4 announces 'updating', but the module does not install itself.

Expected behavior
The module should install itself.

Fix
The problem is caused by the pipeline adding double speechmarks in the module update/version lists CustomName tag in init.mcfunction, see screenshot below.

Screenshots
Image

Environment

  • Minecraft version: 1.14
  • Server version: 1.14 (SP)
  • Installed Datapacks: Ambrosia, Liquid Tanks
  • Installed Mods: None

Additional context
Additional older versions may be affected.

@Bloo-dev Bloo-dev added bug Something isn't working tool This is related to our build pipeline labels Nov 5, 2024
@misode misode self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tool This is related to our build pipeline
Projects
None yet
Development

No branches or pull requests

2 participants