Code review discussion

[metalalive]

If you don't have experience and dunno what to do when reviewing the code done by other co-worker in a PR,
please take a look at the articles :

• Code Review Developer Guide
• How to make good code reviews better - StackOverflow
• TypeScript code review - Microsoft

Hope that helps

[metalalive]

@wingtkw

Teds-lin will NOT continue to contribute the web backend code and discuss all the design issues from today.
Here is my plan for code review and backend development in foreseeable future :

when I open a new github issue for new feature, I will describe what I will implement the feature, and leave it there for 6 hours

• if you happen to see that and you can reply immediately , I will discuss more detail with you
• if you are super busy (for something more important to you) and need to spend significant time like 2 days to 7 days (even more) doing research for the feature , then I will :
  • tag you in the issue (and pull-request) page
  • start the code implementation immediately
  • push commits and merge the code change
  • you can come back at anytime , to see anything goes wrong, and then leave comment to relevant issues / pull-requests, tag me if you have question.

Apologize if you think that is fast-paced development,
I know you are busy to work on a lot of things,
but I'd like to get it done quickly without waiting too long.
Let me know your thought / feedback on this, thanks